VIS: let scatter plots obey mpl color scheme (#3338) #5060
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3338.
Fixes the remaining plot functions that don't follow the matplotlib style (functions based on scatter plots).
Rationale:
c
to default one defined in matplotlibs rcParams ifc
was not specified by the user (becausec='b'
is harcoded in matplotlibscatter
method).color
keyword is not checked because, if specified by the user, it already is given preference by matplotlib overc
if both are given.There is a new PR on scatter based plotting methods (#3473), but I suppose that it can be handled in that PR to ensure this new plotting method also follows this approach?